Add support for variables phcint and amoc to ICON-XPP CMORizer#3025
Merged
Conversation
schlunma
changed the title
phcint_total and amoc to ICON-XPP CMORizerphcint and amoc to ICON-XPP CMORizer
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
==========================================
+ Coverage 96.09% 96.19% +0.09%
==========================================
Files 271 272 +1
Lines 15913 15957 +44
==========================================
+ Hits 15292 15350 +58
+ Misses 621 607 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9 tasks
Contributor
|
Hi all, as part of ESMValCore v2.15.0 release planning, the code freeze is planned for 19 June 2026. This PR is currently on the v2.15.0 milestone. Could you please confirm whether it is expected to be ready for inclusion, or whether it should move to a later milestone? @flicj191 tagging you so this is visible for the release-freeze planning. |
bettina-gier
approved these changes
Jun 18, 2026
bettina-gier
left a comment
bettina-gier
left a comment
Contributor
There was a problem hiding this comment.
Runs fine, results look as expected and match the plots in the recently submitted paper.
rbeucher
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for variables
phcint(new derived variable; will be a non-derived variable in CMIP7) andamocto the ICON-XPP CMORizer.Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: